Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move specs into redux and cleanup oauth related code #976

Merged
merged 15 commits into from
Feb 14, 2022
Merged

chore: move specs into redux and cleanup oauth related code #976

merged 15 commits into from
Feb 14, 2022

Conversation

josephaxisa
Copy link
Contributor

@josephaxisa josephaxisa commented Feb 9, 2022 •
edited
Loading

  • Significantly simplified API Explorer's OAuth flow
  • Specs now live in a redux slice
  • Spec fetching is now only done through ApixEnvAdaptor and ApixExtensionEnvAdaptor
  • Routes now drive the state. This addresses issues where DiffScene state (i.e based on the base and comparison spec keys) was out of sync with the url

@josephaxisa
replace runItSettings and configurator with OAuthConfigProvider
752b2c7
@josephaxisa
move specs to redux and cleanup oauth related code
612c04b 
- Work around non-reentrant code
- Cleanup OAuthScene and more tweaks to initSpecs
- Better memory handling
- chore: clean up extension-utils package.json
- feat: move specs to redux
@josephaxisa
merge main and address conflicts
3aab012
@looker-open-source looker-open-source deleted a comment from github-actions bot Feb 11, 2022
@looker-open-source looker-open-source deleted a comment from github-actions bot Feb 11, 2022
@looker-open-source looker-open-source deleted a comment from github-actions bot Feb 11, 2022
@looker-open-source looker-open-source deleted a comment from github-actions bot Feb 11, 2022
@looker-open-source looker-open-source deleted a comment from github-actions bot Feb 11, 2022
@looker-open-source looker-open-source deleted a comment from github-actions bot Feb 11, 2022
@looker-open-source looker-open-source deleted a comment from github-actions bot Feb 11, 2022
@github-actions
Copy link
Contributor

APIX Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 5971391.

@github-actions
Copy link
Contributor

Typescript Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit 5971391.

@github-actions
Copy link
Contributor

Typescript Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit b100be6.

@github-actions
Copy link
Contributor

APIX Tests

0 files  0 suites   0s ⏱️
0 tests 0 ✔️ 0 💤 0 ❌

Results for commit b100be6.

@github-actions
Copy link
Contributor

APIX Tests

    1 files    78 suites   3m 26s ⏱️
313 tests 300 ✔️ 13 💤 0 ❌
329 runs  316 ✔️ 13 💤 0 ❌

Results for commit 80baeef.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    75 suites   3m 10s ⏱️
169 tests 165 ✔️   4 💤 0 ❌
561 runs  549 ✔️ 12 💤 0 ❌

Results for commit 80baeef.

@github-actions
Copy link
Contributor

Codegen Tests

    1 files    17 suites   26s ⏱️
397 tests 383 ✔️ 14 💤 0 ❌
398 runs  384 ✔️ 14 💤 0 ❌

Results for commit 86fdce7.

@github-actions
Copy link
Contributor

APIX Tests

    1 files    78 suites   3m 40s ⏱️
313 tests 300 ✔️ 13 💤 0 ❌
329 runs  316 ✔️ 13 💤 0 ❌

Results for commit 86fdce7.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    75 suites   2m 54s ⏱️
169 tests 165 ✔️   4 💤 0 ❌
561 runs  549 ✔️ 12 💤 0 ❌

Results for commit 86fdce7.

@github-actions
Copy link
Contributor

Codegen Tests

    1 files    17 suites   25s ⏱️
397 tests 383 ✔️ 14 💤 0 ❌
398 runs  384 ✔️ 14 💤 0 ❌

Results for commit dd70363.

@github-actions
Copy link
Contributor

APIX Tests

    1 files    78 suites   4m 13s ⏱️
313 tests 300 ✔️ 13 💤 0 ❌
329 runs  316 ✔️ 13 💤 0 ❌

Results for commit dd70363.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    75 suites   3m 1s ⏱️
169 tests 165 ✔️   4 💤 0 ❌
561 runs  549 ✔️ 12 💤 0 ❌

Results for commit dd70363.

@github-actions
Copy link
Contributor

Codegen Tests

    1 files    17 suites   29s ⏱️
397 tests 382 ✔️ 14 💤 1 ❌
398 runs  383 ✔️ 14 💤 1 ❌

For more details on these failures, see this check.

Results for commit 69a82b3.

@github-actions
Copy link
Contributor

APIX Tests

    1 files    78 suites   3m 28s ⏱️
313 tests 300 ✔️ 13 💤 0 ❌
329 runs  316 ✔️ 13 💤 0 ❌

Results for commit 69a82b3.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    75 suites   3m 0s ⏱️
169 tests 165 ✔️   4 💤 0 ❌
561 runs  549 ✔️ 12 💤 0 ❌

Results for commit 69a82b3.

@jkaster
changes
42c7879 
- fix package refs
- including 3.1 spec in APIX
@github-actions
Copy link
Contributor

Codegen Tests

    1 files    18 suites   31s ⏱️
403 tests 389 ✔️ 14 💤 0 ❌
404 runs  390 ✔️ 14 💤 0 ❌

Results for commit 42c7879.

@github-actions
Copy link
Contributor

APIX Tests

    1 files    78 suites   3m 36s ⏱️
313 tests 300 ✔️ 13 💤 0 ❌
329 runs  316 ✔️ 13 💤 0 ❌

Results for commit 42c7879.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    75 suites   3m 18s ⏱️
169 tests 165 ✔️   4 💤 0 ❌
561 runs  549 ✔️ 12 💤 0 ❌

Results for commit 42c7879.

@bryans99
fix: DiffScene back/forward browser button behaviour
fc8ab5b 
DiffScene did not handle changes in route when back or forward button
pressed. This change has the react router driving the changes to state.
If diff changes, history is updated. History updates state. When back/forward
button pressed, history is update and again history updates state.
@github-actions
Copy link
Contributor

Codegen Tests

    1 files    18 suites   23s ⏱️
403 tests 389 ✔️ 14 💤 0 ❌
404 runs  390 ✔️ 14 💤 0 ❌

Results for commit fc8ab5b.

@github-actions
Copy link
Contributor

APIX Tests

    1 files    78 suites   3m 36s ⏱️
313 tests 300 ✔️ 13 💤 0 ❌
329 runs  316 ✔️ 13 💤 0 ❌

Results for commit fc8ab5b.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    75 suites   3m 14s ⏱️
169 tests 165 ✔️   4 💤 0 ❌
561 runs  549 ✔️ 12 💤 0 ❌

Results for commit fc8ab5b.

@bryans99
fix: route from diff page
3fd3760 
Setting of current spec has been hoisted to ApiExplorer. ApiExplorer monitors the current
route and sets the current spec if route is different from current spec. Added a check in
the rendering to make sure that the current spec is set correctly before it allows the
router component to render. Renders the loading component instead which I think is okay
but may need to be revisited.

ApiSpecSelector has been modifief to ONLY change the route.

This means that if a component needs to switch spec all it needs to do is modify the route
(diff component showing detail for example).
@github-actions
Copy link
Contributor

Codegen Tests

    1 files    18 suites   28s ⏱️
403 tests 389 ✔️ 14 💤 0 ❌
404 runs  390 ✔️ 14 💤 0 ❌

Results for commit 3fd3760.

@github-actions
Copy link
Contributor

APIX Tests

    1 files    78 suites   4m 1s ⏱️
313 tests 300 ✔️ 13 💤 0 ❌
329 runs  316 ✔️ 13 💤 0 ❌

Results for commit 3fd3760.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    75 suites   2m 59s ⏱️
169 tests 165 ✔️   4 💤 0 ❌
561 runs  549 ✔️ 12 💤 0 ❌

Results for commit 3fd3760.

@github-actions
Copy link
Contributor

Codegen Tests

    1 files    18 suites   30s ⏱️
403 tests 389 ✔️ 14 💤 0 ❌
404 runs  390 ✔️ 14 💤 0 ❌

Results for commit 0a1813d.

@github-actions
Copy link
Contributor

APIX Tests

    1 files    78 suites   4m 11s ⏱️
313 tests 300 ✔️ 13 💤 0 ❌
329 runs  316 ✔️ 13 💤 0 ❌

Results for commit 0a1813d.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files    75 suites   3m 25s ⏱️
169 tests 165 ✔️   4 💤 0 ❌
561 runs  549 ✔️ 12 💤 0 ❌

Results for commit 0a1813d.

jkaster
jkaster approved these changes Feb 12, 2022
View reviewed changes
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified stand-alone OAuth behavior and diff link. Only nit is that RunIt is staying open when perhaps it shouldn't, but that's minor. This is a big step forward.

@josephaxisa josephaxisa merged commit 5e9a221 into main Feb 14, 2022
@josephaxisa josephaxisa deleted the jax/spec-fetching branch February 14, 2022 10:49
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
@github-actions

This comment has been minimized.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkaster jkaster jkaster approved these changes

@bryans99 bryans99 Awaiting requested review from bryans99

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephaxisa @jkaster @bryans99